Rename default export GlimmerComponent to Component#21014
Merged
NullVoxPopuli merged 3 commits intoemberjs:mainfrom Nov 29, 2025
Merged
Rename default export GlimmerComponent to Component#21014NullVoxPopuli merged 3 commits intoemberjs:mainfrom
GlimmerComponent to Component#21014NullVoxPopuli merged 3 commits intoemberjs:mainfrom
Conversation
Contributor
Author
|
An alternative would be to only rename GlimmerComponent, then both would be recommended by typescript. |
Contributor
Author
|
ember's Component export is used in a lot more places than my ide was aware of. I think just renaming the GlimmerComponent should be enough. |
This reverts commit 803f06b.
Contributor
probs better as a separate pr anyway |
Contributor
Estimated Asset SizesDiff Details
|
NullVoxPopuli
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the export is named
GlimmerComponenttypescript is unable to offer it as a suggestion when usingComponent. By convention we have people writeimport Component from '@glimmer/component, as such they will never be suggested the correct import.You have to write
import Gli...to get the correct suggestion.Should have no effect on consumers as this is a default export and as such can be named anything by the consumer.
One risk has been raised by @kategengler in that this might cause problems with the docs and a redirect might need to be added.