rfc: ember-data | deprecate-non-strict-types#740
Conversation
runspired
added
T-ember-data
hjdivad
left a comment
hjdivad
left a comment
There was a problem hiding this comment.
definitely LGTM. Thanks for driving this @runspired
| Deprecates when the `type` for a record provided by a user differs from the resolved | ||
| type, thereby removing the need to configure `ember-inflector` to treat `types` as `uncountable` | ||
| in order to use plural model names, and removing the dasherization constraint. |
There was a problem hiding this comment.
I'd recommend clarifying what "resolved" means in this context.
There was a problem hiding this comment.
The resolved type means the on-disk file-path derived type. So for instance a model at app/models/foos/otherUsers.js has the resolved type foos/otherUsers while app/models/foos/bar-user.js has the resolved type foos/bar-user. For the latter example, foos/barUser and foos/barUsers could both currently be supplied to ember-data in most contexts today and still result in a successful lookup of the model. Said uses would be required to be refactored to use the resolved type.
I'll try to add a note to this effect to the RFC for clarification.
Advance RFC #740 `"EmberData | Deprecate Non Strict Types"` to Stage Ready for Release
Advance RFC #740 `"EmberData | Deprecate Non Strict Types"` to Stage Released
Advance RFC #740 `"EmberData | Deprecate Non Strict Types"` to Stage Recommended
2 participants
Full Text: Rendered