Define _LIBCPP_HAS_MUSL_LIBC in libcxx build#17022
Merged
Conversation
kripken
approved these changes
May 23, 2022
sbc100
force-pushed
the
libcxx_define_musl
branch
from
a0b1939 to
754027f
Compare
This allows us to remove `include/compat/xlocale.h` which it seems was added to support libcxx, but libcxx already has support for musl internally when this macro is defined.
sbc100
force-pushed
the
libcxx_define_musl
branch
from
754027f to
b7cae32
Compare
sbc100
added a commit
that referenced
this pull request
May 31, 2022
This is a parial revert or #17022 ("Define _LIBCPP_HAS_MUSL_LIBC in libcxx build") Alos, add a new test for this header.
sbc100
added a commit
that referenced
this pull request
May 31, 2022
This is a parial revert or #17022 ("Define _LIBCPP_HAS_MUSL_LIBC in libcxx build") Alos, add a new test for this header.
sbc100
added a commit
that referenced
this pull request
Jun 1, 2022
This is a parial revert or #17022 ("Define _LIBCPP_HAS_MUSL_LIBC in libcxx build") Also, add a new test for this header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to remove
include/compat/xlocale.hwhich it seems wasadded to support libcxx, but libcxx already has support for musl
internally when this macro is defined.