Conversation
22 is already taken by auction contracts
Contributor
Author
|
https://github.com/ergoplatform/eips/blob/eip23/eip-0023.md#reward-mechanism Document mentions "We also give a sample token exchange contract", which seems to be missing. Either add the contract or remove the sentence |
greenhat
reviewed
May 11, 2022
greenhat
reviewed
May 11, 2022
greenhat
approved these changes
Jun 23, 2022
Member
greenhat
left a comment
There was a problem hiding this comment.
Looking good!
To be completely sure, I'd wait with PR merging until we implement voting and update operations.
greenhat
reviewed
Aug 4, 2022
Co-authored-by: Denys Zadorozhnyi <[email protected]>
Co-authored-by: Denys Zadorozhnyi <[email protected]>
greenhat
reviewed
Nov 16, 2022
Member
greenhat
reviewed
Nov 23, 2022
EIP23 separate contract files
Rewrite confusing text in description
greenhat
reviewed
Nov 24, 2022
Co-authored-by: Denys Zadorozhnyi <[email protected]>
greenhat
reviewed
Dec 4, 2022
…by ballot boxes; make reward token id and amount optional in ballot box;
We have not given a sample token exchange contract so we should remove the text.
greenhat
reviewed
Jun 27, 2023
…-tokens-check [EIP-0023] In update contract check reward tokens are either preserved or voted by ballot boxes
after changes introduced in 3bd226b hash is calculated in https://scastie.scala-lang.org/W1KaudPGT2WBmJfHDsjlaw
EIP-0023. Let ballot token owner (R4 in ballot box) always spend the ballot box
greenhat
approved these changes
Aug 11, 2023
Member
greenhat
left a comment
There was a problem hiding this comment.
Looks good! I just added the fix to the oracle token transfer process. It's already implemented in the code.
Co-authored-by: Denys Zadorozhnyi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main features in v2.0