EIP-0023. Let ballot token owner (R4 in ballot box) always spend the ballot box#94
Merged
EIP-0023. Let ballot token owner (R4 in ballot box) always spend the ballot box#94
Conversation
after changes introduced in 3bd226b hash is calculated in https://scastie.scala-lang.org/W1KaudPGT2WBmJfHDsjlaw
greenhat
added a commit
to ergoplatform/oracle-core
that referenced
this pull request
Jun 28, 2023
greenhat
changed the title
Contributor
|
Approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following https://github.com/ergoplatform/eips/pull/41/files#r1243427074
Motivation
isSimpleCopyclause forownerrequires minting new ballot tokens for ANY change to the update contract or its parameters (min_votes).I forgot to mint new ballot tokens on changing the update contract and now those ballot tokens cannot be used. See ergoplatform/oracle-core#291 (comment) for details.
Rewriting the final clause as
owner || (isSimpleCopy && update)would allow to keep using existing ballot tokens since voting is done by ballot owners (PK check).