changed column name to remove duplicate#509
Merged
erikdarlingdata merged 3 commits intoerikdarlingdata:devfrom Dec 10, 2024
Merged
changed column name to remove duplicate#509erikdarlingdata merged 3 commits intoerikdarlingdata:devfrom
erikdarlingdata merged 3 commits intoerikdarlingdata:devfrom
Conversation
changed the second column named blocked_process_report to blocked_process_report_xml
erikdarlingdata
requested changes
Dec 10, 2024
Owner
erikdarlingdata
left a comment
erikdarlingdata
left a comment
There was a problem hiding this comment.
Since you're not used to GitHub, I'm going to point you to a helpful thing:
- Please review the contributing guide
I've linked directly to the code standards section. There is one point in there directly related to this PR, and another close by.
- Column aliases using the "column = expression" format - you've not done that, but the opposite of that. It should be
blocked_process_report_xml = b.blocked_process_report - Using AS in table aliases we are not dodo birds, we capitalize key words in our SQL.
Contributor
Author
|
ope, somehow missed that |
erikdarlingdata
added
the
sp_HumanEventsBlockViewer
Owner
|
@DForck42 thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed the second column named blocked_process_report to blocked_process_report_xml