sp_QuickieStore: Multiple changes to how wait stats are handled#590
Merged
erikdarlingdata merged 1 commit intoerikdarlingdata:devfrom Apr 27, 2025
Merged
sp_QuickieStore: Multiple changes to how wait stats are handled#590erikdarlingdata merged 1 commit intoerikdarlingdata:devfrom
erikdarlingdata merged 1 commit intoerikdarlingdata:devfrom
Conversation
…ting multiple databases. * Moved checking for instance-level problems with asking for wait stats to before we check for database-level problems. * Made the warning message about invalid sort orders on particular versions honest, closing #575. * Updated the new @ColumnDefinitions table variable to respect cases where we change sort order. * Added a comment on an edge case that we ignore, as well as some expert mode output warning of it. * When hitting multiple databases and asking for something that cares about wait stats, made us skip any databases with capturing wait stats disabled.
erikdarlingdata
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple changes to how wait stats are handled, particularly when hitting multiple databases.
@ColumnDefinitionstable variable to respect cases where we change sort order.There are enough changes here that I'm sure that I'll have missed an edge case. I have also not run this on a 2016 box. I am otherwise entirely happy with it. I was surprised by how much work this needed. Some of it was related to the new
@ColumnDefinitionstable variable, but I think that many parts were always broken.