Made filtering by @execution_count be done with a temp table rather than a variable#593
Merged
erikdarlingdata merged 1 commit intoerikdarlingdata:devfrom Apr 28, 2025
Merged
Conversation
…han a variable. This closes #576. In particular, the filter now works at the query level rather than the plan level. Because this temp table is references by @where_clause, we no longer need @having_clause. Given that @where_clause is used by almost everything, we can now be much more confident that filtering by @execution_count works properly everywhere.
Owner
|
@ReeceGoding great work here, thank you! |
erikdarlingdata
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made filtering by
@execution_countbe done with a temp table rather than a variable.This closes #576. In particular, the filter now works at the query level rather than the plan level.
Because this temp table is references by
@where_clause, we no longer need@having_clause. Given that@where_clauseis used by almost everything, we can now be much more confident that filtering by@execution_countworks properly everywhere.I have to admit that this worked almost too well. The example given in #576 worked correctly on my first try. I don't like it when that happens.
The query that this used was similar to what friend of the repo @zikato suggested. I used window functions instead because I wanted to keep the ways that I was hitting the Query Store DMVs simple.