sp_QuickieStore: Moved validation of @sort_order to be much earlier on.#602
Merged
erikdarlingdata merged 2 commits intoerikdarlingdata:devfrom May 4, 2025
Merged
sp_QuickieStore: Moved validation of @sort_order to be much earlier on.#602erikdarlingdata merged 2 commits intoerikdarlingdata:devfrom
erikdarlingdata merged 2 commits intoerikdarlingdata:devfrom
Conversation
… it's much better than the bugs that come with relying on @sort_order to populate @ColumnDefinitions before you have validated @sort_order. Since this change was to close #601, I have made all checks of if sort order is a wait be done by the @sort_order_is_a_wait variable. This is how we did it before 5.1.
erikdarlingdata
added
bug
ReeceGoding
referenced
this pull request
in ReeceGoding/DarlingData
May 14, 2025
…e build up the table variable. Fixes #611 and is very similar to #602.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's ugly, but it's much better than the bugs that come with relying on
@sort_orderto populate@ColumnDefinitionsbefore you have validated@sort_order.Since this change was to close #601, I have made all checks of if sort order is a wait be done by the
@sort_order_is_a_waitvariable. This is how we did it before 5.1.