sp_QuickieStore: Move regression validation to just after sort order#612
Merged
erikdarlingdata merged 2 commits intoerikdarlingdata:devfrom May 14, 2025
Conversation
…e build up the table variable. Fixes #611 and is very similar to #602.
erikdarlingdata
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved all validation of the regression mode parameters to be before we build up the table variable. Fixes #611 and is very similar to #602.
Also standardised checks for regression mode being enabled.
This PR marks the end of me checking over the old example file for anything that broke since
@ColumnDefinitionswas added. Hopefully everything is now working like it used to.