Removed unneeded undef min|max, they no longer clash with vector et al#3856
Removed unneeded undef min|max, they no longer clash with vector et al#3856devyte wants to merge 15 commits intoesp8266:masterfrom devyte:deadcode
Conversation
|
@igrr I need a bit of help with this one. I wanted to remove two remaining #undef min|max left over from before the Arduino.h fix submitted some days ago (see top commit above), but Travis failed when building tests. To my surprise, I found another Arduino.h in there, which has fallen behind vs. the core one. I tried bringing it somewhat to par with the current Arduino.h, specifically with the min|max fix, but the build still fails, this time complaining about isnan etc already defined. |
|
@igrr ping |
|
Alright, it looks like there is no point to pursue this under gcc 4.x. From what I can gather, the whole isnan/isinf thing was known under gcc >= 4.6, and a patch was applied at some point later (I couldn't figure out the details). Probably gcc 5.x has it. |
|
To 3.0.0 as we'll probably be on GCC 9 for that release and will be able to use this. |
Remove a straggler `undef min/max` from core header Supersedes esp8266#3856
No description provided.