Merged
Conversation
Collaborator
|
Merging this after confirmation from several users. |
Contributor
Author
|
Note that this change appears to have broken RF_CAL, see the on going discussion in #3408 (comment) |
Collaborator
|
@torntrousers should this be rolled back, new changes added on top, or is further investigation needed to figure out the problem/solution? |
Contributor
Author
|
Its really unclear what RF calibration does, for me it appears to work ok without calibration running, and there's the work around of using an RF_PRE_INIT function to force calibration to run - #3408 (comment). And without this change here its impossible to get the fast startup times which make running off small batteries practical. So IMHO I'd prefer this fix to stay on, at least for now. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #3408 (comment) undo the change in e02932f. I've tried the sketch in #619 that the commit was original done to fix and it does work now without the commit.