Add glob-style pattern matching to webserver uri handling#5467
Closed
devyte wants to merge 1 commit intoesp8266:masterfrom
devyte:fnmatch
Closed
Add glob-style pattern matching to webserver uri handling#5467devyte wants to merge 1 commit intoesp8266:masterfrom devyte:fnmatch
devyte wants to merge 1 commit intoesp8266:masterfrom
devyte:fnmatch
Conversation
earlephilhower
requested changes
Mar 12, 2019
Collaborator
earlephilhower
left a comment
earlephilhower
left a comment
There was a problem hiding this comment.
I like the sheer simplicity of this, but I think we need to put in its use in an example somewhere.
The original bug talks about using the last bit as a parameter to something else. Maybe have this set a PWM value on the LED pin in the example, taking a URI of /pwm/* and parsing out the final integer?
earlephilhower
added
merge-conflict
Collaborator
|
Thanks for your PR, but the core and libraries have changed enough that this PR now has a merge conflict. Could you merge it manually with the latest core, so we can consider it for future releases? |
Closed
Collaborator
Author
|
Closing in favor of #6696 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2019 .
This is an alternate proposal to #5214 .
This adds glob-style pattern matching to the webserver uri handling. Glob patterns are what is used in command line. Examples:
server.on("/devices/*", devicesCB)would match any request that starts with /devices/ and call the devicesCB callback.server.on("/led?", ...)would match a request that starts with /led and is followed by one char, such as /led1 or /ledA.server.on("*yomama*", ...)would match a request that contains yomama anywhere in it.For more details see
man globorman fnmatchunder *nix.