Skip to content

platform.txt - to work as referred package#5770

Closed
JAndrassy wants to merge 4 commits intoesp8266:masterfrom
JAndrassy:issue5769
Closed

platform.txt - to work as referred package#5770
JAndrassy wants to merge 4 commits intoesp8266:masterfrom
JAndrassy:issue5769

Conversation

@JAndrassy
Copy link
Contributor

@JAndrassy JAndrassy commented Feb 16, 2019 •
edited
Loading

{build.core.path} used instead of {runtime.platform.path} to work as
referred package for Arduino 3rd-party-Hardware-specification chapter
"Referencing another core, variant or tool"

solving #5769

note: the keys removed at release are unchanged. referring the package in dev setup doesn't work

comment: This will allow end users to define preferred sets of boards settings (example) and manufacturers of esp8266 boards could create 'satellite' board packages using core and tools of this main esp8266 package.

JAndrassy and others added 2 commits February 16, 2019 10:42
@JAndrassy
platform.txt - to work as referred package
de2a908 
{build.core.path} used instead of {runtime.platform.path} to work as
referred package for Arduino 3rd-party-Hardware-specification chapter
"Referencing another core, variant or tool"
@JAndrassy
Merge branch 'master' into issue5769
58383ec
@JAndrassy JAndrassy mentioned this pull request Feb 16, 2019
Open
@JAndrassy
Copy link
Contributor Author

JAndrassy commented Feb 18, 2019 •
edited
Loading

after 9790e1c it is unclear to me which lines will stay in platform.txt after release.

@d-a-v
Copy link
Collaborator

d-a-v commented Feb 18, 2019 •
edited
Loading

I fixed conflicts by hand. You need to check whether it still works as referred package.
You will also need to git submodule update --init

edit there are some {runtime.platform.path} left and empty lines that I may have been added while fixing by hand

@JAndrassy
Copy link
Contributor Author

JAndrassy commented Feb 18, 2019 •
edited
Loading

I left {runtime.platform.path} in the lines that are removed at release. The runtime.tools.* work with {build.core.path} too, but the tools.* don't.
One of the runtime.tools.*, the signing.py stayed in release in 2.5.0, so I changed the path for it to {build.core.path}
It is unclear know, I think, which of the runtime.tools.* will stay for release, so we can simply use {build.core.path} in all runtime.tools.*.
I will see if I can test it by making a fake release installation. Before I tested it on 2.5.0 release.

@JAndrassy
Copy link
Contributor Author

JAndrassy commented Feb 19, 2019 •
edited
Loading

some entries (tools.^) don't work in dev 'mode' with {build.core.path}/../.., but need it after installation to work as referred package. most prominent problematic entry is

tools.esptool.upload.pattern="{cmd}" "{runtime.platform.path}/tools/upload.py" "{runtime.platform.path}/tools/pyserial" "{runtime.platform.path}/tools/esptool/esptool.py" --chip esp8266 --port "{serial.port}" --baud "{upload.speed}" "{upload.verbose}" {upload.erase_cmd} --end  --chip esp8266 --port "{serial.port}" --baud "{upload.speed}" "{upload.verbose}" write_flash 0x0 "{build.path}/{build.project_name}.bin" --end

I don't know what to do with it? It looks like it is not a problem of the changes, but I missed something as I tested it before. It looks like I must close this for now.

@JAndrassy JAndrassy closed this Feb 20, 2019
@d-a-v
Copy link
Collaborator

d-a-v commented Feb 20, 2019

Serial upload with windows was broken, and has just been fixed (#5796).
Maybe you can retry with your changes.

@JAndrassy
Copy link
Contributor Author

JAndrassy commented Feb 20, 2019 •
edited by d-a-v
Loading

Serial upload with windows was broken, and has just been fixed (#5796).
Maybe you can retry with your changes.

I am on Linux. Things worked in git version only not as referred package.

@d-a-v d-a-v mentioned this pull request Sep 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d-a-v d-a-v d-a-v approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JAndrassy @d-a-v