PROGMEM footprint cleanup for responseCodeToString#6950
Merged
devyte merged 3 commits intoesp8266:masterfrom Dec 27, 2019
Merged
PROGMEM footprint cleanup for responseCodeToString#6950devyte merged 3 commits intoesp8266:masterfrom
devyte merged 3 commits intoesp8266:masterfrom
Conversation
Doing returns with String/FlashStringHelper conversion for every case means that the code for doing that is duplicated, which is wasteful. doing it only once saves about 250 bytes (50%) of code size.
dirkmueller
force-pushed
the
http_responsecodtostring
branch
from
e38d8b8 to
89e8700
Compare
devyte
requested changes
Dec 27, 2019
earlephilhower
approved these changes
Dec 27, 2019
Collaborator
earlephilhower
left a comment
earlephilhower
left a comment
There was a problem hiding this comment.
+1 on @devyte's comment request, but OTW good for me!
devyte
approved these changes
Dec 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing returns with String/FlashStringHelper conversion for every
case means that the code for doing that is duplicated, which
is wasteful. doing it only once saves about 250 bytes (50%) of
code size.