configTime(tzsec,dstsec,): fix UTC/local management#6993
Merged
d-a-v merged 11 commits intoesp8266:masterfrom Feb 18, 2020
Merged
configTime(tzsec,dstsec,): fix UTC/local management#6993d-a-v merged 11 commits intoesp8266:masterfrom
d-a-v merged 11 commits intoesp8266:masterfrom
Conversation
This PR also remove dead code since probably newlib updates The NTP-TZ-DST example is also updated
6 tasks
Collaborator
|
Any PR that drops 300+ lines of legacy, unmaintained code w/o dropping functionality is awesome! |
earlephilhower
requested changes
Jan 22, 2020
Collaborator
earlephilhower
left a comment
earlephilhower
left a comment
There was a problem hiding this comment.
Little worried about the signed->unsigned on timezone_secs. Other stuff very minor. Looking good...
earlephilhower
approved these changes
Jan 22, 2020
6 tasks
devyte
approved these changes
Feb 18, 2020
|
For some reason after this was merged my sntp code stopped working. Undefined references to the once documented SNTP API calls by espressif:
I guess some functionality has been dropped... |
Collaborator
|
@arendst can you open a new issue on this? This is closed-merged, so anything here won't show up on our lists w/o explicitly looking for it. |
|
Done. |
6 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also removes dead code since probably newlib updates.
The NTP-TZ-DST example is updated.
fixes #6921
fixes #6678