Reduce mem footprint of ESP.getResetInfo()#7030
Merged
earlephilhower merged 1 commit intoesp8266:masterfrom Jan 22, 2020
Merged
Reduce mem footprint of ESP.getResetInfo()#7030earlephilhower merged 1 commit intoesp8266:masterfrom
earlephilhower merged 1 commit intoesp8266:masterfrom
Conversation
This function has excessively long datastrings that can better be stored in flash, reducing runtime memory footprint. Also detailed formatting only makes sense when there is an exception or a watchdog. In other cases instead of printing an unhelpful "flag: 0" we can just return the ResetReason, which is much more readable. Saves about 120 bytes of (data) memory.
d-a-v
approved these changes
Jan 21, 2020
|
Thanks for your effort reducing memory footpront 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function has excessively long datastrings that can
better be stored in flash, reducing runtime memory footprint.
Also detailed formatting only makes sense when there is an
exception or a watchdog. In other cases instead of printing
an unhelpful "flag: 0" we can just return the ResetReason, which
is much more readable.
Saves about 120 bytes of (data) memory.