You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a sketch does not check server::available() often enough, short connections are now received and stored in background (backlog limit number of connections at most) and can be retrieved and used by subsequent client = server::available(). Those clients will be status() == CLOSED, connected() == false but available() > 0.
@kirillandy Could you check this ? I get what's expected by #2569 with these changes.
@JAndrassy This is still not what you are waiting for but it would be nice if you checked nothing has changed on the arduino side (WiFiClient::operator bool() has changed).
Hi @d-a-v ! Currently trying to check your changes out, but I'm not too certain about my actions.
So I installed the current ESP Arduino library version using Git (as the docs instruct). After a bit of research I then used "git merge https://github.com/d-a-v/Arduino.git FixBacklogHonorEphemeral" to apply your changes on what I have locally stored on my PC.
Is that all I need to do before I compile my code to test out on my ESPs?
(Also, if my actions were correct, was there an easier way to do what I did? :D)
UPDATE:
So, if everything I did to get hold of your commit was correct (still need some friendly guidance on that, since this is my first time properly using Git and its commands :)), then everything works like a charm! I repeated my previous experiment by sending a few bytes when the server was not available-looping and the server was able to get the client and read the bytes 👍
I also tried sending bytes in 3 different connections one after the other to check if they'd all be in the queue and the server managed to .available() all 3 and read every message.
Thanks a lot for your work, @d-a-v!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a sketch does not check
server::available()often enough, short connections are now received and stored in background (backlog limit number of connections at most) and can be retrieved and used by subsequentclient = server::available(). Those clients will bestatus() == CLOSED,connected() == falsebutavailable() > 0.@kirillandy Could you check this ? I get what's expected by #2569 with these changes.
@JAndrassy This is still not what you are waiting for but it would be nice if you checked nothing has changed on the arduino side (
WiFiClient::operator bool()has changed).fixes #2569
edit:
fixes #7103