Add flash helper constructor to Uri#7105
Merged
earlephilhower merged 2 commits intomasterfrom Feb 23, 2020
Merged
Conversation
6 tasks
earlephilhower
requested changes
Feb 23, 2020
Collaborator
earlephilhower
left a comment
earlephilhower
left a comment
There was a problem hiding this comment.
Could we change one of the example strings to a FPSTR()? Just to catch this if it happens again?
Collaborator
Author
|
@earlephilhower I could do a different pr for that after this one is merged. I'm Chuck Norrising this from my phone via webedit while on the road. |
Convert a c-str to a FPSTR in the example to have a section of code in our CI that will catch any future breaks of this specific kind.
earlephilhower
approved these changes
Feb 23, 2020
Collaborator
earlephilhower
left a comment
earlephilhower
left a comment
There was a problem hiding this comment.
Just tested a snippet in the example:
server.on(F("/"), []() {
server.send(200, "text/plain", "hello from esp8266!");
});
It fails w/master and passes with this. Updated one example for you such that master fails w/@TD-er's error and passes with this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7102