Tone limit 20KHz #7179
Merged
earlephilhower merged 7 commits intoesp8266:masterfrom Apr 4, 2020
Tech-TX:tone_limit_comments
Merged
Tone limit 20KHz #7179earlephilhower merged 7 commits intoesp8266:masterfrom Tech-TX:tone_limit_comments
earlephilhower merged 7 commits intoesp8266:masterfrom
Tech-TX:tone_limit_comments
Conversation
earlephilhower
requested changes
Apr 1, 2020
Collaborator
earlephilhower
left a comment
earlephilhower
left a comment
There was a problem hiding this comment.
Thanks for the add'l comment, but I can see no reason not to extend the range by default to 20kHz like you were mentioning.
Contributor
Author
|
Done, and done! I'll good with removing artificial restraints on operation. 😄 |
Contributor
Author
|
FYI, I've already tested this change yesterday much farther than 20KHz. When I tried to take it to 65535 it blew up, but I sort of expected that based on your notes elsewhere about CPU utilization at 40KHz PWM. |
devyte
approved these changes
Apr 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 2 comments since I found out where the 5KHz upper limit on Tone output frequency was, apparently added for compatibility with the Arduino library some time in the past.
If you want the full 20KHz audio frequency range, change the two lines in Tone.cpp at line 38 to: