Update HTML in CaptivePortal examples for better mobile device viewing ...#7227
Merged
d-a-v merged 2 commits intoesp8266:masterfrom Apr 19, 2020
Merged
Update HTML in CaptivePortal examples for better mobile device viewing ...#7227d-a-v merged 2 commits intoesp8266:masterfrom
d-a-v merged 2 commits intoesp8266:masterfrom
Conversation
Added meta viewport element for better mobile device viewing. For example CaptivePortalAdvanced, increased size of ssid and password array to hold maximums 32 and 64 charcter strings. Added missing HTML elments to main splash and wifi config. They should now pass an HTML checker. Also added meta viewport element for better mobile device viewing.
devyte
approved these changes
Apr 18, 2020
d-a-v
approved these changes
Apr 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example CaptivePortal, update HTML to pass HTML checker.
Added meta viewport element for better mobile device viewing.
For example, CaptivePortalAdvanced, increased size of ssid and password array
to hold maximums 32 and 64 character strings. Added missing HTML elements
to the main splash and wifi config. pages. They should now pass an HTML checker.
Also added meta viewport element for better mobile device viewing.