ESP8266WebServer: Add variadic template version of collectHeaders()#7296
Merged
earlephilhower merged 2 commits intoesp8266:masterfrom Mar 15, 2021
Merged
Conversation
Collaborator
|
@jjsuwa, it looks like this changes the API in a way that breaks existing examples. Can you check the Travis CI logs and see? |
Contributor
Author
|
Hmm, Travis CI notification stalled? |
jjsuwa
force-pushed
the
WebServer_collectHeaders_VT
branch
5 times, most recently
from
135ac22 to
2c5c987
Compare
jjsuwa
force-pushed
the
WebServer_collectHeaders_VT
branch
5 times, most recently
from
7fe8662 to
c9c046f
Compare
jjsuwa
force-pushed
the
WebServer_collectHeaders_VT
branch
8 times, most recently
from
6f3fe64 to
043345c
Compare
jjsuwa
force-pushed
the
WebServer_collectHeaders_VT
branch
4 times, most recently
from
bfdd076 to
029c160
Compare
jjsuwa
force-pushed
the
WebServer_collectHeaders_VT
branch
5 times, most recently
from
4e1303e to
f71eca5
Compare
jjsuwa
force-pushed
the
WebServer_collectHeaders_VT
branch
from
f71eca5 to
71b3a99
Compare
jjsuwa
force-pushed
the
WebServer_collectHeaders_VT
branch
5 times, most recently
from
79af719 to
c94e389
Compare
d-a-v
approved these changes
Jul 17, 2020
Collaborator
d-a-v
left a comment
d-a-v
left a comment
There was a problem hiding this comment.
approving the templatoid variadicoid collectHeaderoid, thanks !
jjsuwa
force-pushed
the
WebServer_collectHeaders_VT
branch
3 times, most recently
from
2686eed to
ced25ea
Compare
jjsuwa
force-pushed
the
WebServer_collectHeaders_VT
branch
6 times, most recently
from
a604914 to
db39012
Compare
jjsuwa
force-pushed
the
WebServer_collectHeaders_VT
branch
3 times, most recently
from
695a997 to
4a40d36
Compare
Collaborator
|
@devyte, this is some deep template voodoo. Can you give it a look-see? |
jjsuwa
force-pushed
the
WebServer_collectHeaders_VT
branch
from
65ce6b6 to
ef0bb25
Compare
Contributor
Author
|
Should |
devyte
requested changes
Aug 9, 2020
jjsuwa
force-pushed
the
WebServer_collectHeaders_VT
branch
from
ef0bb25 to
7a75371
Compare
* More user-friendly, less RODATA usage.
eg. `webServer.collectHeaders(F("Content-Type"), F("Origin"));`
In this example, less about 20 bytes than the traditional way.
jjsuwa
force-pushed
the
WebServer_collectHeaders_VT
branch
from
7a75371 to
ef79356
Compare
devyte
approved these changes
Mar 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eg.
webServer.collectHeaders(F("Content-Type"), F("Origin"));In this example, less about 20 bytes than the traditional way.