elf2bin.py objcopy cleanup#7351
Merged
earlephilhower merged 4 commits intoesp8266:masterfrom Jun 6, 2020
Merged
Conversation
earlephilhower
approved these changes
Jun 6, 2020
Collaborator
earlephilhower
left a comment
earlephilhower
left a comment
There was a problem hiding this comment.
Good fix, but needs to have #7348 merged before it can go in. The TemporaryDirectory method isn't available in Python2 (which is the only one installed on Macs until the very latest release AFAIK).
Using a mkdtemp call and cleaning up afterward would allow it to go in even if #7348 isn't merged as that's available since Python2.
mcspr
commented
Jun 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per https://docs.python.org/3/library/tempfile.html#tempfile.mkstemp
read_segment()'sdumpfilewas never deleted, producing 5 'segment' files each build.Instead, this patch creates a temporary directory which is later used for objcopy output.
TemporaryDirectory()context manager will handle the deletion.Plus, some minor refactoring to reduce line length and add some pythonisms (hopefully, not too much)
Noticed this issue accidentally by inspecting a specific Windows PC install using WSL circa January.
/tmpwas ~2.5GB and there was a lot of files.