Fix the bad address of the the AP if the settings are wrong#7363
Merged
devyte merged 2 commits intoesp8266:masterfrom Jun 8, 2020
Merged
Fix the bad address of the the AP if the settings are wrong#7363devyte merged 2 commits intoesp8266:masterfrom
devyte merged 2 commits intoesp8266:masterfrom
Conversation
Fix the bad adress of the the AP if the settings are wrong
d-a-v
approved these changes
Jun 8, 2020
Collaborator
|
This is a long standing bug. We don't support user reliance on a bug. Moving to 2.7.2. |
Collaborator
|
@dumarjo thanls for this. Also, shame on me, because I know I've seen that line in the past, and wondered about it. |
thekurtovic
reviewed
Jun 10, 2020
thekurtovic
left a comment
thekurtovic
left a comment
There was a problem hiding this comment.
ret = softAPConfig(0x0104A8C0, 0x00F4A8C0, 0x00FFFFFF);
should be
ret = softAPConfig(0x0104A8C0, 0x0104A8C0, 0x00FFFFFF);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This should fix the problem seen from time to time on our device. The default IP should be 192.168.4.1 and not 192.168.244.1
This should fix this issue: #5627