Add a "-- CUT HERE --" marker to exception output#7369
Merged
earlephilhower merged 1 commit intoesp8266:masterfrom Jun 11, 2020
Merged
Add a "-- CUT HERE --" marker to exception output#7369earlephilhower merged 1 commit intoesp8266:masterfrom
earlephilhower merged 1 commit intoesp8266:masterfrom
Conversation
Users aren't reporting/seeing the actual PC of failures because they are only copying the >>stack<< into the decoder and not the Exception line. Add an ALL CAPS "CUT HERE FOR EXCEPTION DECODER" line to the output to make it blindingly obvious to include the full crashdump both in bug reports as well as exception decodes.
d-a-v
approved these changes
Jun 11, 2020
Collaborator
d-a-v
left a comment
d-a-v
left a comment
There was a problem hiding this comment.
Users like to be guided, this is appreciated
Collaborator
Author
|
An example of the modified output: The decoder works w/ or w/o the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users aren't reporting/seeing the actual PC of failures because they
are only copying the >>stack<< into the decoder and not the Exception
line. Add an ALL CAPS "CUT HERE FOR EXCEPTION DECODER" line to the
output to make it blindingly obvious to include the full crashdump
both in bug reports as well as exception decodes.