Merged
Conversation
… wrapper to handle the context
Collaborator
earlephilhower
left a comment
earlephilhower
left a comment
There was a problem hiding this comment.
Wow, you did a lot of work!
Generally seems fine, but the extra jump for every call just grates me the wrong way...I can't think of any way around it. Performance-wise, it should not be an issue since the SSL guts are very slow and this only adds 5-6 instructions per high-level call. @devyte may have some ideas here.
Collaborator
|
New changes look good. I need to run some tests on HW locally before approving, as this is straightforward but pretty big impact... |
d-a-v
changed the title
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
How it is done:
WiFiClientSecureclass toWiFiClientSecureCtxWiFiClientSecurewith a single member as shared ptr to aWiFiClientSecureCtx*Both
WiFiClientSecureandWiFiClientSecureCtxderive fromWiFiClient, butWiFiClientSecure's one is not used. Instead, all its virtual functions call its context's ones.Tested with
BearSSL_MaxFragmentLength.ino