Merged
Conversation
Timezones coded with <±nn>±nn<±nn>[±nn][,...] are incorrectly parsed by newlib's TZ parser. In these timezones, <±nn> is used because there is no matching name like in other timezones. Example: 'GMT0BST' for London, (GMT is known, BST is 'British Summer Time'). Example: '<+1030>-10:30<+11>-11' for Lord Howe Island. These names GMT,BST,CET,... are meant to be human readable but are useless in our use case. Replacing <±nn> occurences by UNK allows newlib's TZ parser to nicely interpret all timezones. Ultimately, newlib should handle such tz descriptor. Until then, they are handled by this script.
6 tasks
earlephilhower
approved these changes
Nov 10, 2020
Collaborator
|
Would you like to put in a bug on the newlib repo for this change? https://github.com/earlephilhower/newlib-xtensa |
Collaborator
Author
earlephilhower
added a commit
to earlephilhower/Arduino
that referenced
this pull request
Nov 12, 2020
Undoes the change in esp8266#7699 and fixed esp8266#7690 root cause. Newlib did not support timezone names of the form "<[+-]?[0-9]+>" and would parse the offset using the <name>. Fix newlib tzset parser with earlephilhower/newlib-xtensa#14 and undo the UNK changes used as an expedient workaround.
earlephilhower
added a commit
that referenced
this pull request
Nov 12, 2020
Undoes the change in #7699 and fixed #7690 root cause. Newlib did not support timezone names of the form "<[+-]?[0-9]+>" and would parse the offset using the <name>. Fix newlib tzset parser with earlephilhower/newlib-xtensa#14 earlephilhower/newlib-xtensa#15 and undo the UNK changes used as an expedient workaround.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timezones coded with
<±nn>±nn<±nn>[±nn][,...]are incorrectly parsed by newlib's TZ parser.In these timezones,
<±nn>is used because there is no matching name like in other timezones.Example:
GMT0BSTfor London, (GMT is known, BST isBritish Summer Time).<+1030>-10:30<+11>-11for Lord Howe Island.These names GMT,BST,CET,... are meant to be human readable but are useless in our use case.
Replacing
<±nn>occurences byUNKnown allows newlib's TZ parser to nicely interpret all timezones.UNK-10:30UNK-11is then correctly parsed.Ultimately, newlib should handle such TZ descriptors. Until then, they are handled by this script.
Fixes #7690