Improvements to non 32-bit exception handler#7816
Merged
earlephilhower merged 2 commits intoesp8266:masterfrom Jan 8, 2021
Merged
Improvements to non 32-bit exception handler#7816earlephilhower merged 2 commits intoesp8266:masterfrom
earlephilhower merged 2 commits intoesp8266:masterfrom
Conversation
resets. It seems you should not use input registers for scratch registers. Add an extra output register instead. No code size increase. Light refactoring for readability Added "C" reference code for Extended ASM Save two cycles by loading a0 early in exc-c-wrapper-handler.S Use optimization O2 Net change in size, 0 bytes with optimization. Save 4 bytes w/o Optimization. With changes and "O2" save 3 cycles on write and 6 cycles on read.
earlephilhower
approved these changes
Jan 8, 2021
Collaborator
earlephilhower
left a comment
earlephilhower
left a comment
There was a problem hiding this comment.
LGTM! I think you found and fixed an occasional issue I was having w/the PSRAM virtual mem version of this, too. Good debugging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended ASM got fussy when using different optimizations. ie. HWDT resets. It seems you should not use input registers for scratch registers. Fixed by adding an extra output register for temporary values. No code size increase. Now works with different optimizations.
Light refactoring for readability
Added "C" reference code for Extended ASM
Save two cycles by loading
a0early inexc-c-wrapper-handler.SUse optimization
O2Net change in size, 0 bytes with optimization. Save 4 bytes w/o Optimization.
With changes and
O2save 3 cycles on write and 6 cycles on read.