Update toolchain to support std::remainder#7849
Merged
earlephilhower merged 3 commits intoesp8266:masterfrom Jan 29, 2021
Merged
Update toolchain to support std::remainder#7849earlephilhower merged 3 commits intoesp8266:masterfrom
earlephilhower merged 3 commits intoesp8266:masterfrom
Conversation
Update newlib to enable the __iee745_remainder(f) calls required by std::remainder and others. Fixes esp8266#7845
Collaborator
|
#7845 successfully builds using Windows toolchain, no surprises so far Does this need a test similar to this? Arduino/tests/device/test_sw_newlib/test_sw_newlib.ino Lines 27 to 31 in 39d1453 to at least call it once |
Collaborator
Author
|
Good idea, @mcspr . Since it's in newlib and not the core the chance of it re-breaking is low but I'll throw something in so that it at least checks linkage (the base problem here) once somewhere... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update newlib to enable the __ieee754_remainder(f) calls required by
std::remainder and others.
Fixes #7845