Open
Conversation
Collaborator
|
Thanks ! namespace esp8266
{
using polledTimeout = ::PolledTimeout [[ deprecated, "use PolledTimeout instead of esp8266::polledTimeout" ]];
}This fixes #7903 |
…red, fix includes
Collaborator
Author
I intend this to be a strong breaking change. I don't want the legacy naming to be dragged into the future. |
Contributor
|
@devyte The copyright header is AWOL in |
d-a-v
reviewed
Apr 7, 2021
|
|
||
| // legacy type names, deprecated (unit is milliseconds) | ||
| using oneShot = TimeoutTemplate<false, YieldPolicy::DoNothing, TimePolicy::TimeMillis>; | ||
| using periodic = TimeoutTemplate<true, YieldPolicy::DoNothing, TimePolicy::TimeMillis>; |
Collaborator
There was a problem hiding this comment.
Why are these kept in this breaking change commit ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7903
This PR restructures the polledtimeout code by separating the templates from the policies, which makes it easier for users to understand how to extend the code with new custom policies. It also separates* the generic policies that should be common to all Arduino cores from the policies that are specific to the esp8266.
The namespaces and template name have been changed to uppercase based on multiple feedback received since the frist version was implemented.
As usual, the specifics are up for discussion.