Add code-spell spelling checks to CI#8067
Merged
earlephilhower merged 10 commits intoesp8266:masterfrom May 23, 2021
Merged
Conversation
Help find and fix silly spelling errors as they are added to the repo.
Need to manually exclude certain files because code-spell interprets things like PEM keys as words and not line noise.
d-a-v
approved these changes
May 21, 2021
Collaborator
d-a-v
left a comment
d-a-v
left a comment
There was a problem hiding this comment.
After updating 132 files 👀, checks have passed !
Contributor
|
Nice, sources look a lot more professional in an instant. Now if merging were an exact science, I could sleep calmly, but as it stands, and I've seen it happen, git and/or subsequent 3-way-merge editors have produced artifacts at times. And given the sheer number of files this PR touches, it's more likely something goes astray for already pending PRs once this were to get merged into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Help find and fix silly spelling errors as they are added to the repo.