github action: enforce issue detection with bash #8168
Merged
earlephilhower merged 5 commits intoesp8266:masterfrom Jun 24, 2021
Merged
github action: enforce issue detection with bash #8168earlephilhower merged 5 commits intoesp8266:masterfrom
earlephilhower merged 5 commits intoesp8266:masterfrom
Conversation
mcspr
reviewed
Jun 23, 2021
| run: | | ||
| # Sets an environment variable used in the next steps | ||
| echo "TRAVIS_TAG=$(git describe --exact-match --tags)" >> $GITHUB_ENV | ||
| TRAVIS_TAG=$(git describe --exact-match --tags)" |
Collaborator
There was a problem hiding this comment.
Suggested change
| TRAVIS_TAG=$(git describe --exact-match --tags)" | |
| TRAVIS_TAG=$(git describe --exact-match --tags) |
(I typed this wrong)
Collaborator
Author
There was a problem hiding this comment.
Thanks for reviewing (I didn't make a copy-paste, It's simply that I made the same mistake)
earlephilhower
approved these changes
Jun 24, 2021
Collaborator
earlephilhower
left a comment
earlephilhower
left a comment
There was a problem hiding this comment.
Silly GH CI bug, good catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion with @mcspr.
When not specifiying
bashas running shell, default options do not include-o pipefailas it should.It may not prevent a script to stop when one component of a pipe chain fails (ex:
false | truewon't fail but it should).As a consequence in this PR,
bashis explicitely specified as default shell.Also enforcing issue detection by breaking down commands
echo "$(command)" >> file=>var=$(command)thenecho ${var} >> file