Adding custom buffer_length using I2C_BUFFER_LENGTH#8390
Merged
d-a-v merged 4 commits intoesp8266:masterfrom Dec 1, 2021
Merged
Adding custom buffer_length using I2C_BUFFER_LENGTH#8390d-a-v merged 4 commits intoesp8266:masterfrom
d-a-v merged 4 commits intoesp8266:masterfrom
Conversation
d-a-v
approved these changes
Nov 28, 2021
Collaborator
d-a-v
left a comment
d-a-v
left a comment
There was a problem hiding this comment.
Approving.
As mentioned in the other closed PR, rx/txBufferIndex and rx/txBufferLength should be made into 16 or 32 bits. I guess this will be for another PR.
Collaborator
|
If you are running with linux or wsl2, there's the |
Contributor
Author
|
The style should match what it's expecting now - Also merged changes from master. |
Contributor
Author
|
Missing anything in order for this to get merged? |
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
* Adding custom buffer_length using I2C_BUFFER_LENGTH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New PR that expands on #8388.
Changed it so it's the same setting name (
I2C_BUFFER_LENGTH) on both ESP8266 and ESP32 Wire library.