WiFiServer - don't inherit from Server class#8418
Merged
d-a-v merged 5 commits intoesp8266:masterfrom Jan 3, 2022
Merged
Conversation
Fixes esp8266#8416 We install now a private Python and use it for OTA calls, so users do not need to manually install anything.
JAndrassy
force-pushed
the
WiFiServer_not_inherit
branch
from
b05eb8c to
fbe7abb
Compare
d-a-v
approved these changes
Jan 3, 2022
Collaborator
d-a-v
left a comment
d-a-v
left a comment
There was a problem hiding this comment.
Looks good.
It is a non-sense for WiFiServer to inherit from Print without implementing properly Print functions.
OK to assume it is not a breaking change.
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
* WiFiServer - don't inherit from Server class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base type Server is useless because it doesn't declare any method to get a client so it can't be used as base type reference or pointer.
Server inherits from Print, but ESP8266WiFi library's WiFiServer doesn't implement the print-to-all-clients functionality, inheriting from Print only adds virtual methods overhead.
My addition the ArduinoWiFiServer class implements the print-to-all-clients functionality so it needs to inherit from Print.
I created and maintain two networking libraries (WiFiEspAT and EnternetENC) and both don't use the Server class and have a separate class for server with print-to-all-clients functionality. There are no issues with this.
EDIT: It is not a breaking change.