Merged
Conversation
Isolate NULL/panic test of _context to dev debug assert macro. Use abort instead of panic for case of caller providing non-heap address pointer. Added debug print. Improved get_unpoisoned_check_neighbors to print file/line when available.
d-a-v
approved these changes
Feb 15, 2022
Collaborator
d-a-v
left a comment
d-a-v
left a comment
There was a problem hiding this comment.
Nothing jumps at me in this code simplification.
Thank you for keeping improving the undergrounds and UMM
Collaborator
|
Should be ok to merge then? |
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
Isolate NULL/panic test of _context to dev debug assert macro. Use abort instead of panic for case of caller providing non-heap address pointer. Added debug print. Improved get_unpoisoned_check_neighbors to print file/line when available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isolate NULL/panic test of
_contextto dev debug assert macro.Use abort instead of panic for the case of the caller providing a non-heap address pointer.
get_unpoisoned_check_neighborsto print file/line when available.