Permit using the Updater _hash function, even if we don't have a signature appended to the image#8472
Closed
einglis wants to merge 5 commits intoesp8266:masterfrom
einglis:master
Closed
Permit using the Updater _hash function, even if we don't have a signature appended to the image#8472einglis wants to merge 5 commits intoesp8266:masterfrom einglis:master
einglis wants to merge 5 commits intoesp8266:masterfrom
einglis:master
Conversation
…ature appended to the image
Contributor
Author
|
Hold on. This line:
still ends up subtracting an extra uint32_t from the total image length, so the hash function doesn't get to see all the data. Sorry I didn't catch this sooner. |
… hash function, even if the expected signature length was zero, and added some clarifying comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _hash and _verify functionality of the Updater class are pretty much entwined. But it might be useful to calculate the hash, even without a signature present in the image itself. This change permits that by allowing a zero-length signature.
For reference, one possible use case is where the expected hash is provided separately to the uploaded image. Another is to provide generic post-upload validation of the image: the hash function permits a convenient way of inspecting the complete image against arbitrary conditions; this is particularly useful after HTTP client OTA updates.
(It's fair that reading the whole image back out of flash is not very efficient, but that's not the concern of this PR.)