do not call tcp/udp ::stopAll() when it is not required to do so#8598
Merged
d-a-v merged 3 commits intoesp8266:masterfrom Jun 23, 2022
Merged
do not call tcp/udp ::stopAll() when it is not required to do so#8598d-a-v merged 3 commits intoesp8266:masterfrom
d-a-v merged 3 commits intoesp8266:masterfrom
Conversation
Collaborator
|
ArduinoOTA as well? Even a failed update kills every client Continuing the idea, Arduino/libraries/ArduinoOTA/ArduinoOTA.h Lines 50 to 61 in 8bfc2e9 Where the user might as well do the WiFiClient::stopAll();
WiFiUDP::stopAll();// or, where we want some fine grained control
WiFiClient::stopAllExcept(&server.client());
WiFiUDP::stopAllExcept(&myPreciousCnC); |
mcspr
approved these changes
Jun 23, 2022
d-a-v
changed the title
mcspr
added a commit
that referenced
this pull request
Nov 3, 2022
follow-up of #8598 similar to ArduinoOTA API, execute certain callback in the Updater context.
6 tasks
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
…8266#8598) * do not call tcp/udp ::stopAll() when it is not required to to so * remove stopAll also from ArduinoOTA
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
follow-up of esp8266#8598 similar to ArduinoOTA API, execute certain callback in the Updater context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6123