Safeguard for Ticker internal storage that may be changed during callback execution#8820
Merged
mcspr merged 4 commits intoesp8266:masterfrom Jan 26, 2023
Merged
Safeguard for Ticker internal storage that may be changed during callback execution#8820mcspr merged 4 commits intoesp8266:masterfrom
mcspr merged 4 commits intoesp8266:masterfrom
Conversation
Mainly, we protect std::function and variant itself from undefined
behaviour when the underlying object is destroyed and then re-created
with something else inside of it.
For example, every captured object would be destroyed.
```cpp
Ticker ticker;
void oops(Job job) {
ticker.once(1.0f,
[job = std::move(job)]() {
ticker.once(job.next(), do_something_else);
job.work(); // ~Job() just happened!
});
}
```
Another important case is repeating through once()
```cpp
Ticker ticker;
void repeat() {
ticker.once(1.0f, repeat);
puts("tick");
}
void setup() {
repeat();
}
```
Temporarily moving callback object into the function and returning
earlier should solve both cases.
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
…back execution (esp8266#8820) Temporarily move callback into the function scope and execute it from there. Detaching would no longer destroy it, and re-scheduling would no longer be almost immediately cancelled by our code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly, we protect std::function and variant itself from undefined behaviour when the underlying object is destroyed and then re-created with something else inside of it.
For example, every captured object would be destroyed.
Another important case is repeating through once() (since why not)
Using temporary variable in the static_callback func and returning earlier should solve both cases.