SdFat -> FS HAL mode fixes & test#8833
Merged
mcspr merged 2 commits intoesp8266:masterfrom Jan 31, 2023
Merged
Conversation
* re-use SdFat value through static const, no need to hard-code our values w/ cast in the macro * separate read-modes from flags * simple compile-time tests in .cpp resolve esp8266#8831
Collaborator
Collaborator
Author
|
'New' thing is |
d-a-v
approved these changes
Jan 31, 2023
Collaborator
d-a-v
left a comment
d-a-v
left a comment
There was a problem hiding this comment.
Nice debug.
Reason is: upstream O_READ was 1 and now is 0 since our release v3.
Thanks
mcspr
changed the title
earlephilhower
added a commit
to earlephilhower/arduino-pico
that referenced
this pull request
Feb 11, 2023
Pull in the portion of the change correcting the flag setting from esp8266/Arduino#8833
earlephilhower
added a commit
to earlephilhower/arduino-pico
that referenced
this pull request
Feb 11, 2023
Pull in the portion of the change correcting the flag setting from esp8266/Arduino#8833
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
* re-use SdFat access mode through static const, no need to hard-code our own value w/ cast in the macro * separate read-modes from flags; read, write and rw are distinct numbers * simple compile-time tests in .cpp resolve esp8266#8831
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #8831