chore(feemarket) - Depreacte usage of x/params in x/feemarket by Vvaradinov · Pull Request #1509 · evmos/ethermint

Vvaradinov · 2022-11-29T12:21:37Z

Deprecates the now legacy Cosmos SDK x/params usage in x/feemarket module. For more info regarding changes check out #1472

Closes: ENG-1107

Description

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

linear · 2022-11-29T12:21:39Z

ENG-1107 Deprecate Cosmos x/params logic from FeeMarket module

This is in relation to ENG-965

rpc/backend/chain_info.go

…le code

….com/evmos/ethermint into Vvaradinov/refactor-feemarket-params

codecov · 2022-11-29T19:47:42Z

Codecov Report

Merging #1509 (e7fd485) into main (8886ce3) will decrease coverage by 0.20%.
The diff coverage is 67.85%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
- Coverage   68.40%   68.19%   -0.21%     
==========================================
  Files         106      110       +4     
  Lines       10077    10087      +10     
==========================================
- Hits         6893     6879      -14     
- Misses       2783     2801      +18     
- Partials      401      407       +6

Impacted Files	Coverage Δ
x/feemarket/types/codec.go	`45.45% <45.45%> (ø)`
x/feemarket/keeper/keeper.go	`86.66% <50.00%> (-4.64%)`	⬇️
x/feemarket/types/msg.go	`50.00% <50.00%> (ø)`
x/feemarket/keeper/params.go	`68.42% <63.63%> (-20.87%)`	⬇️
x/feemarket/keeper/msg_server.go	`66.66% <66.66%> (ø)`
x/feemarket/migrations/v4/migrate.go	`83.33% <83.33%> (ø)`
app/app.go	`84.90% <100.00%> (+0.02%)`	⬆️
x/feemarket/keeper/migrations.go	`100.00% <100.00%> (+100.00%)`	⬆️
x/feemarket/types/params.go	`87.69% <100.00%> (-5.42%)`	⬇️
... and 2 more

….com/evmos/ethermint into Vvaradinov/refactor-feemarket-params

GAtom22

Awesome work @Vvaradinov!! Left a few questions and comments, LMK your thoughts

proto/ethermint/feemarket/v1/tx.proto

x/feemarket/genesis.go

proto/ethermint/feemarket/v1/tx.proto

x/feemarket/keeper/msg_server.go

x/feemarket/migrations/v4/migrate.go

x/feemarket/module.go

x/feemarket/types/msg.go

Co-authored-by: Tomas Guerra <[email protected]>

….com/evmos/ethermint into Vvaradinov/refactor-feemarket-params

MalteHerrmann

tACK! Good stuff @Vvaradinov, left some small comments

proto/ethermint/feemarket/v1/feemarket.proto

x/feemarket/keeper/keeper.go

x/feemarket/keeper/msg_server.go

x/feemarket/keeper/params.go

x/feemarket/types/codec.go

x/feemarket/types/params.go

proto/ethermint/feemarket/v1/tx.proto

Co-authored-by: MalteHerrmann <[email protected]>

fedekunze

LGTM. We should improve coverage in the msg.go file

x/feemarket/keeper/params.go

Co-authored-by: Federico Kunze Küllmer <[email protected]>

fedekunze

@Vvaradinov requesting some additional changes that we discussed in Slack

x/feemarket/keeper/keeper.go

x/feemarket/keeper/msg_server.go

x/feemarket/keeper/params.go

x/feemarket/types/msg.go

Co-authored-by: Federico Kunze Küllmer <[email protected]>

x/feemarket/keeper/params.go

(refactor): Added new MsgUpdateParams tx and generated new proto files

d49eb1b

Vvaradinov self-assigned this Nov 29, 2022

github-actions bot added C:Proto protobuf files (*.pb.go) Type: Build codebase build process labels Nov 29, 2022

(refactor): Refactor for migration of x/params

9f6ebea

github-advanced-security bot found potential problems Nov 29, 2022

View reviewed changes

rpc/backend/chain_info.go Fixed Show fixed Hide fixed

rpc/backend/chain_info.go Fixed Show fixed Hide fixed

Vvaradinov added 7 commits November 29, 2022 20:58

(fix): Refactor to use single Params store key for easier more readab…

dd53d2e

…le code

(fix): removed unused

b0b53a7

(fix): add validation

c62bfc3

Merge branch 'main' into Vvaradinov/refactor-feemarket-params

1ddab52

(fix): fix linter

ad0e605

remove line

248a326

Merge branch 'Vvaradinov/refactor-feemarket-params' of https://github…

2258375

….com/evmos/ethermint into Vvaradinov/refactor-feemarket-params

github-actions bot removed the Type: Build codebase build process label Nov 29, 2022

Vvaradinov requested a review from fedekunze November 29, 2022 21:41

Vvaradinov marked this pull request as ready for review November 29, 2022 21:41

Vvaradinov requested a review from a team as a code owner November 29, 2022 21:41

Vvaradinov requested review from hanchon and removed request for a team November 29, 2022 21:41

Vvaradinov added 7 commits December 1, 2022 10:53

Added changes from code review

b3a02d0

Merge branch 'main' into Vvaradinov/refactor-feemarket-params

aec42ab

Apply changes from code review

902bef8

Merge branch 'Vvaradinov/refactor-feemarket-params' of https://github…

02bc49c

….com/evmos/ethermint into Vvaradinov/refactor-feemarket-params

(fix): Made ParamKey back to a string

b3be8c5

Added CHANGELOG entry

7382120

Merge branch 'main' into Vvaradinov/refactor-feemarket-params

dfd77e3

GAtom22 reviewed Dec 12, 2022

View reviewed changes

Apply suggestions from code review

752d0d9

Co-authored-by: Tomas Guerra <[email protected]>

Vvaradinov added 2 commits December 12, 2022 16:19

(fix): remove HTTP endpoint exposure

0f6098d

Merge branch 'Vvaradinov/refactor-feemarket-params' of https://github…

89a5cd7

….com/evmos/ethermint into Vvaradinov/refactor-feemarket-params

MalteHerrmann reviewed Dec 12, 2022

View reviewed changes

Apply suggestions from code review

0ace96b

Co-authored-by: MalteHerrmann <[email protected]>

MalteHerrmann mentioned this pull request Dec 12, 2022

chore(inflation): Deprecate x/params usage in x/inflation evmos/evmos#1107

Merged

12 tasks

fix: Apply changes from code review and run linter

58ca91a

MalteHerrmann mentioned this pull request Dec 15, 2022

chore(recovery): Deprecate x/params usage in x/recovery evmos/evmos#1131

Merged

12 tasks

fedekunze approved these changes Dec 15, 2022

View reviewed changes

x/feemarket/keeper/params.go Outdated Show resolved Hide resolved

MalteHerrmann mentioned this pull request Dec 15, 2022

chore(incentives): Deprecate x/params usage in x/incentives evmos/evmos#1130

Merged

12 tasks

Update x/feemarket/keeper/params.go

f0363f4

Co-authored-by: Federico Kunze Küllmer <[email protected]>

fedekunze suggested changes Dec 16, 2022

View reviewed changes

x/feemarket/keeper/keeper.go Show resolved Hide resolved

x/feemarket/keeper/msg_server.go Show resolved Hide resolved

x/feemarket/keeper/params.go Show resolved Hide resolved

x/feemarket/types/msg.go Show resolved Hide resolved

x/feemarket/types/msg.go Outdated Show resolved Hide resolved

Vvaradinov and others added 3 commits December 19, 2022 10:13

Update x/feemarket/types/msg.go

922aec2

Co-authored-by: Federico Kunze Küllmer <[email protected]>

tests: added tests for msg_server and msg

fa697c7

Merge branch 'main' into Vvaradinov/refactor-feemarket-params

60f7267

Vvaradinov mentioned this pull request Dec 19, 2022

Identify usage of GetBaseFeeV1 #1562

Closed

Vvaradinov added 2 commits December 19, 2022 10:59

tests: add failing test for migration

e66eac8

Merge branch 'main' into Vvaradinov/refactor-feemarket-params

1edc17b

Vvaradinov requested a review from fedekunze January 3, 2023 16:37

Vvaradinov added 3 commits January 3, 2023 19:18

Merge branch 'main' into Vvaradinov/refactor-feemarket-params

bb363c7

Merge branch 'main' into Vvaradinov/refactor-feemarket-params

3f6581d

Merge branch 'main' into Vvaradinov/refactor-feemarket-params

5462da8

fedekunze approved these changes Jan 5, 2023

View reviewed changes

x/feemarket/keeper/params.go Outdated Show resolved Hide resolved

Update x/feemarket/keeper/params.go

e7fd485

fedekunze enabled auto-merge (squash) January 5, 2023 16:29

fedekunze disabled auto-merge January 5, 2023 16:59

fedekunze merged commit 57ed355 into main Jan 5, 2023

fedekunze deleted the Vvaradinov/refactor-feemarket-params branch January 5, 2023 16:59

Conversation

Vvaradinov commented Nov 29, 2022

Description

Uh oh!

linear bot commented Nov 29, 2022

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Nov 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

GAtom22 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MalteHerrmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fedekunze left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fedekunze left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Nov 29, 2022 •

edited

Loading

fedekunze left a comment •

edited

Loading