This repository was archived by the owner on Apr 4, 2024. It is now read-only.
Merged
Conversation
GAtom22
requested review from
adisaran64 and
facs95
and removed request for
a team
GAtom22
changed the title
GAtom22
requested review from
4rgon4ut,
MalteHerrmann,
Vvaradinov,
danburck and
fedekunze
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1566 +/- ##
==========================================
+ Coverage 68.63% 68.65% +0.02%
==========================================
Files 103 103
Lines 9946 9953 +7
==========================================
+ Hits 6826 6833 +7
Misses 2737 2737
Partials 383 383
|
fedekunze
approved these changes
Dec 21, 2022
Contributor
Author
@fedekunze It's a little tricky to test it.. I'll try to write a test for this case. IMO this error should be returned.. Maybe the fix would be to add it to the |
facs95
approved these changes
Dec 22, 2022
MalteHerrmann
pushed a commit
that referenced
this pull request
Dec 22, 2022
* fix(abci): fix reCheckTx gas wanted' * fix(ante): add changelog entry
Merged
fedekunze
added a commit
that referenced
this pull request
Dec 22, 2022
* build(deps): bump github.com/cosmos/cosmos-sdk from 0.46.6 to 0.46.7 (#1551) Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.46.6 to 0.46.7. - [Release notes](https://github.com/cosmos/cosmos-sdk/releases) - [Changelog](https://github.com/cosmos/cosmos-sdk/blob/main/CHANGELOG.md) - [Commits](cosmos/cosmos-sdk@v0.46.6...v0.46.7) --- updated-dependencies: - dependency-name: github.com/cosmos/cosmos-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/cosmos/ibc-go/v5 from 5.1.0 to 5.2.0 (#1564) Bumps [github.com/cosmos/ibc-go/v5](https://github.com/cosmos/ibc-go) from 5.1.0 to 5.2.0. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v5.2.0/CHANGELOG.md) - [Commits](cosmos/ibc-go@v5.1.0...v5.2.0) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * make missing key error message during SendTransaction more verbose (#1563) Co-authored-by: 4rgon4ut <[email protected]> * debug(app): add flag to disable optimized build for remote debugging (#1549) Co-authored-by: MalteHerrmann <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> * Problem: personal_newAccount don't work (#1561) fix the internal parameter. * fix(ante): fix reCheckTx gas wanted (#1566) * fix(abci): fix reCheckTx gas wanted' * fix(ante): add changelog entry * fix(cli): fix Ledger signature algorithm verification (#1550) * fix: update Ledger default algorithm to `EthSecp256k1` * fix ledger signing algo validation * changelog Co-authored-by: Freddy Caceres <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> * update changelog Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: 4rgon4ut <[email protected]> Co-authored-by: Tomas Guerra <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: yihuang <[email protected]> Co-authored-by: Austin Chandra <[email protected]> Co-authored-by: Freddy Caceres <[email protected]>
This was referenced Dec 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes:
Description
Set
gasWanted = 0for Txs inReCheckModeat theEthGasConsumeDecoratorAnteHandler. Otherwise, Tendermint logs this error:However, this error is not bubbled up and the Tx never runs on
DeliverMode.For more details, check the related issue's comments.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)