This repository was archived by the owner on Apr 4, 2024. It is now read-only.
evm: fixed commented out simulations, pubsub, and handler tests#655
Merged
fedekunze merged 2 commits intoevmos:mainfrom Oct 11, 2021
Merged
evm: fixed commented out simulations, pubsub, and handler tests#655fedekunze merged 2 commits intoevmos:mainfrom
fedekunze merged 2 commits intoevmos:mainfrom
Conversation
fixes evmos#640 simulations are very basic: they can be built and executed, but they don't generate any EVM-related transactions yet. (It should be a matter of adding simulation-related code to the modules + potentially extra helpers to the simulation.) handler tests miss some extra assertions due to changes in the return values snapshotting logic (ADR-001 and ADR-002). Besides the test suites identified in the audit, there's also "importer_test.go" which wasn't yet fixed. (it'd require major rewriting + extra test resources)
tomtau
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
Codecov Report
@@ Coverage Diff @@
## main #655 +/- ##
==========================================
+ Coverage 55.88% 57.04% +1.15%
==========================================
Files 63 63
Lines 5518 5534 +16
==========================================
+ Hits 3084 3157 +73
+ Misses 2271 2214 -57
Partials 163 163
|
fedekunze
approved these changes
Oct 11, 2021
Contributor
fedekunze
left a comment
fedekunze
left a comment
There was a problem hiding this comment.
ACK, although the simulation pkg on the SDK doesn't work with EthAccounts and eth_secp256k1 keys, so it's not possible to simulate/fuzz EVM txs. Let's open a follow up issue to track that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #640
Description
simulations are very basic: they can be built and executed,
but they don't generate any EVM-related transactions yet.
(It should be a matter of adding simulation-related code to the
modules + potentially extra helpers to the simulation.)
handler tests miss some extra assertions due to changes
in the return values snapshotting logic (ADR-001 and ADR-002).
Besides the test suites identified in the audit,
there's also "importer_test.go" which wasn't yet fixed.
(it'd require major rewriting + extra test resources)
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)