Merged
Conversation
Contributor
Author
|
update: I did grep on VERSION_CHECK_FOO , no hit |
added 2 commits
June 8, 2025 18:59
Signed-off-by: Ramon Fincken <[email protected]>
Signed-off-by: Ramon Fincken <[email protected]>
ramonfincken
force-pushed
the
patch-update-browsers-bin
branch
from
f94e173 to
738d4fe
Compare
rmccue
reviewed
Jun 9, 2025
| # Update the browser regex in the version check script. | ||
| # | ||
| # Uses a browserslist query to generate this data. | ||
| # Needs you to run `npx browserslist-useragent-regexp "defaults, unreleased versions"` before first use |
Member
There was a problem hiding this comment.
Hmm, why is this required, because npx prompts for install?
Contributor
Author
There was a problem hiding this comment.
Yes correct. I needed to enter "y"
Contributor
Author
There was a problem hiding this comment.
so I have npm/npx installed. But the command needed a one time only "y" manual enter to work
Member
There was a problem hiding this comment.
Got it; instead of this comment, let's add --yes to the npx command which should ensure it runs automatically instead :)
Contributor
|
@rmccue Does the code change need to be in this PR? If not, let's see if we can get this in for 1.1 |
Ipstenu
added
the
needs review
rmccue
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not need the line VERSION_CHECK_FOO on ubuntu. Please double check if this is the case for all OS'es.
Also , before running ... you need to actually run npx manually, otherwhise the $() command waits forever to say "yes"
this might be "solved" by doing this with pipe yes ( | yes )