Support for rules_oci 2.x (using bzlmod)#40
Merged
apesternikov merged 1 commit intofasterci:mainfrom Jul 16, 2024
Merged
Conversation
apesternikov
approved these changes
Jul 16, 2024
Contributor
apesternikov
left a comment
apesternikov
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
I will make another pass to replace yq dependency with jq in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered two issues when upgrading to
rules_oci2.x. The same issues were also raised on Bazel Slack here.@rules_oci//oci:repositories.bzlno longer exports aLATEST_CRANE_VERSIONvariable. I refactoredrepositories.bzland extracted toolchain-related stuff used by the bzlmod extension to a newtoolchains.bzl.repositories.bzlstill requiresLATEST_CRANE_VERSION, but it's no longer loaded by the bzlmod extension, so doesn't cause failures.oci_pushno longer depends on theyqtoolchain. I've updatedpush_oci_ruleto explicitly depend on theyqtoolchain in addition to whatever else the underlyingoci_pushimplementation depends on.