Skip to content

[CDTOOL-1265] Move vcl commands under service#1616

Merged
rcaril merged 11 commits intomainfrom
rcaril/CDTOOL-1265-move-fastly-vcl-commands-under-service
Jan 15, 2026
Merged

[CDTOOL-1265] Move vcl commands under service#1616
rcaril merged 11 commits intomainfrom
rcaril/CDTOOL-1265-move-fastly-vcl-commands-under-service

Conversation

@rcaril
Copy link
Contributor

@rcaril rcaril commented Jan 13, 2026 •
edited
Loading

Change summary

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
// Sampled a few tests, they all seems to run
make test TEST_ARGS="-run TestConditionCreate ./pkg/commands/service/vcl/condition"
ok      github.com/fastly/cli/pkg/commands/service/vcl/condition        1.050s
make test TEST_ARGS="-run TestCustomCreate ./pkg/commands/service/vcl/custom"
ok      github.com/fastly/cli/pkg/commands/service/vcl/custom   1.024s [no tests to run]
make test TEST_ARGS="-run TestSnippetCreate ./pkg/commands/service/vcl/snippet"
ok      github.com/fastly/cli/pkg/commands/service/vcl/snippet  1.022s [no tests to run]
make test TEST_ARGS="-run TestVCLDescribe ./pkg/commands/service/vcl"
ok      github.com/fastly/cli/pkg/commands/service/vcl  1.063s

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

None as alias' have been implemented.

@rcaril rcaril marked this pull request as ready for review January 13, 2026 21:06
@rcaril rcaril requested a review from a team as a code owner January 13, 2026 21:06
@rcaril rcaril requested a review from kpfleming January 13, 2026 21:06
rcaril
rcaril commented Jan 13, 2026
View reviewed changes
@rcaril rcaril marked this pull request as draft January 13, 2026 21:08
@rcaril
Copy link
Contributor Author

rcaril commented Jan 13, 2026

I realized the alias work still needs to be done, so moving this back to draft.

@rcaril rcaril marked this pull request as ready for review January 15, 2026 15:09
@rcaril
Copy link
Contributor Author

rcaril commented Jan 15, 2026 •
edited
Loading

Somehow the last commands.go conflict merge broke something. Reviewing this now.

kpfleming
kpfleming requested changes Jan 15, 2026
View reviewed changes
Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes, otherwise this looks great!

@rcaril rcaril requested a review from kpfleming January 15, 2026 18:52
kpfleming
kpfleming reviewed Jan 15, 2026
View reviewed changes
@rcaril rcaril requested a review from kpfleming January 15, 2026 19:05
kpfleming
kpfleming approved these changes Jan 15, 2026
View reviewed changes
Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, this is ready to go!

@rcaril rcaril merged commit b13bb8e into main Jan 15, 2026
13 checks passed
@rcaril rcaril deleted the rcaril/CDTOOL-1265-move-fastly-vcl-commands-under-service branch January 15, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpfleming kpfleming kpfleming approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rcaril @kpfleming