Skip to content

[CDTOOL-1259] Move the logging command under service#1642

Merged
rcaril merged 8 commits intomainfrom
CDTOOL-1259-move-logging-under-service
Jan 30, 2026
Merged

[CDTOOL-1259] Move the logging command under service#1642
rcaril merged 8 commits intomainfrom
CDTOOL-1259-move-logging-under-service

Conversation

@rcaril
Copy link
Contributor

@rcaril rcaril commented Jan 28, 2026 •
edited
Loading

Change summary

This PR moves the logging command under the service command. A alias for fastly logging X has been added here to prevent breaking changes.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

None, alias' have been added to prevent breaking changes.

@anthony-gomez-fastly
Copy link
Contributor

anthony-gomez-fastly commented Jan 29, 2026 

 cli git:(CDTOOL-1259-move-logging-under-service) make lint       
==> Installing golangci-lint v2.4.0
==> Checking golangci-lint version
==> Running golangci-lint
INFO golangci-lint has version 2.4.0 built with go1.25.5 from (unknown, modified: ?, mod sum: "h1:qz6O6vr7kVzXJqyvHjHSz5fA3D+PM8v96QU5gxZCNWM=") on (unknown) 
INFO [config_reader] Config search paths: [./ /Users/anthonygomez/src/fastly/cli /Users/anthonygomez/src/fastly /Users/anthonygomez/src /Users/anthonygomez /Users /] 
INFO [config_reader] Used config file .golangci.yml 
INFO [config_reader] Module name "github.com/fastly/cli" 
INFO maxprocs: Leaving GOMAXPROCS=12: CPU quota undefined 
INFO [goenv] Read go env for 10.139917ms: map[string]string{"GOCACHE":"/Users/anthonygomez/Library/Caches/go-build", "GOROOT":"/usr/local/go"} 
INFO [lintersdb] Active 20 linters: [durationcheck errcheck exhaustive forcetypeassert gocritic godot gofumpt goimports gosec govet ineffassign makezero misspell nilerr predeclared revive staticcheck unconvert unparam unused] 
INFO [loader] Go packages loading at mode 8767 (compiled_files|files|imports|types_sizes|deps|exports_file|name) took 1.289982292s 
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 44.701291ms 
INFO [linters_context/goanalysis] analyzers took 0s with no stages 
INFO [runner/exclusion_paths] Skipped 0 issues by pattern "builtin$" 
INFO [runner/exclusion_paths] Skipped 0 issues by pattern "examples$" 
INFO [runner/exclusion_paths] Skipped 0 issues by pattern "third_party$" 
INFO [runner/exclusion_rules] Skipped 0 issues by rules: [Path: "examples$", Linters: "gofumpt, goimports"] 
INFO [runner/exclusion_rules] Skipped 0 issues by rules: [Path: "third_party$", Linters: "gofumpt, goimports"] 
INFO [runner/exclusion_rules] Skipped 0 issues by rules: [Path: "builtin$", Linters: "gofumpt, goimports"] 
INFO [runner] Issues before processing: 1323, after processing: 0 
INFO [runner] Processors filtering stat (in/out): generated_file_filter: 1323/1323, exclusion_rules: 1323/3, filename_unadjuster: 1323/1323, invalid_issue: 1323/1323, exclusion_paths: 1323/1323, nolint_filter: 3/0, path_absoluter: 1323/1323, cgo: 1323/1323, path_relativity: 1323/1323 
INFO [runner] processing took 11.447038ms with stages: generated_file_filter: 4.861667ms, exclusion_rules: 4.264874ms, nolint_filter: 1.386541ms, path_relativity: 659µs, exclusion_paths: 197.416µs, cgo: 26.292µs, invalid_issue: 24.708µs, path_absoluter: 14.209µs, sort_results: 6.082µs, filename_unadjuster: 3.875µs, max_same_issues: 917ns, fixer: 292ns, source_code: 249ns, path_prettifier: 167ns, path_shortener: 167ns, max_per_file_from_linter: 166ns, diff: 166ns, uniq_by_line: 126ns, max_from_linter: 124ns, severity-rules: 0s 
INFO [runner] linters took 572.372375ms with stages: goanalysis_metalinter: 560.886708ms 
0 issues.
INFO File cache stats: 0 entries of total size 0B 
INFO Memory: 21 samples, avg is 55.8MB, max is 101.3MB 
INFO Execution took 1.918691375s

@rcaril rcaril changed the title [CDTOOL-1259] [CDTOOL-1259] Move the logging command under service Jan 29, 2026
@rcaril rcaril marked this pull request as ready for review January 29, 2026 18:19
@rcaril rcaril requested a review from a team as a code owner January 29, 2026 18:19
kpfleming
kpfleming previously requested changes Jan 29, 2026
View reviewed changes
Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. All (or at least most) of the describe and list commands support JSON output, so they will need the deprecation message suppressed.

  2. We should check with the Bulleit team to confirm that all of these logging endpoints are still available; the last time I checked at least one (maybe Loggly or Logshuttle) was out of business. This would be a good time to remove commands for logging services that can no longer be used.

@rcaril
Copy link
Contributor Author

rcaril commented Jan 29, 2026

Pending feedback from the logging team.

kpfleming
kpfleming approved these changes Jan 29, 2026
View reviewed changes
Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We should wait a bit to see if we get feedback about removing any of the logging endpoints, but if we don't then this is ready to merge.

@rcaril
Copy link
Contributor Author

rcaril commented Jan 30, 2026

We have confirmation that none of these logging commands are deprecated. I'll be merging this PR now.

@rcaril rcaril merged commit a5f999a into main Jan 30, 2026
13 checks passed
@rcaril rcaril deleted the CDTOOL-1259-move-logging-under-service branch January 30, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpfleming kpfleming kpfleming approved these changes

@anthony-gomez-fastly anthony-gomez-fastly Awaiting requested review from anthony-gomez-fastly anthony-gomez-fastly is a code owner automatically assigned from fastly/developer-tools

@philippschulte philippschulte Awaiting requested review from philippschulte

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rcaril @anthony-gomez-fastly @kpfleming