Skip to content

Add Rust 1.93.0 to the Rust version blocklist.#1653

Merged
kpfleming merged 4 commits intofastly:mainfrom
dgohman-fastly:dgohman-fastly/rust-1.93.0
Mar 4, 2026
Merged

Add Rust 1.93.0 to the Rust version blocklist.#1653
kpfleming merged 4 commits intofastly:mainfrom
dgohman-fastly:dgohman-fastly/rust-1.93.0

Conversation

@dgohman-fastly
Copy link
Contributor

Change summary

Rust 1.93.0 has a bug in the wasm32-wasip2 target, so it doesn't affect current Fastly users, however there are potential future use cases affected by it, so add a blocklist rule for it.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

User Impact

Users using Rust 1.93.0 will need to upgrade to Rust 1.93.1.

Rust 1.93.0 has a bug in the wasm32-wasip2 target, so it doesn't affect
current Fastly users, however there are future use cases which could be
affected by it, so add a blocklist rule for it.
@dgohman-fastly dgohman-fastly requested a review from a team as a code owner February 12, 2026 21:46
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgohman-fastly Confirmed with my team: this isn’t a breaking change, since it doesn’t impact any existing Fastly users. Could you please update the changelog entry to reflect that? Thanks!

@dgohman-fastly
Copy link
Contributor Author

@dgohman-fastly Confirmed with my team: this isn’t a breaking change, since it doesn’t impact any existing Fastly users. Could you please update the changelog entry to reflect that? Thanks!

Done.

@kpfleming
Copy link
Contributor

I'm not even sure this is useful; at the moment the CLI doesn't even have the ability to build for the wasm32-wasip2 target, and by the time it does Rust 1.93.0 will be a somewhat distant memory. It's definitely not harmful, but I want to be careful to not set a precedent of adding version blocks for versions whose faults can't affect users of the tool at that time.

@kpfleming kpfleming dismissed philippschulte’s stale review March 4, 2026 19:26

Changes were made

@kpfleming kpfleming enabled auto-merge (squash) March 4, 2026 19:26
@kpfleming kpfleming merged commit a720700 into fastly:main Mar 4, 2026
9 checks passed
@dgohman-fastly dgohman-fastly deleted the dgohman-fastly/rust-1.93.0 branch March 9, 2026 15:37
jedisct1 added a commit that referenced this pull request Mar 17, 2026
Both PRs were merged after the v14.0.4 release.
jedisct1 added a commit that referenced this pull request Mar 17, 2026
### Change summary

Moved two changelog entries from the v14.0.0 section to Unreleased, as
both PRs were merged after v14.0.4 was tagged:

  - #1653 - feat(compute/build): Block version 1.93.0 of Rust
- #1637 - feat(service/vcl): escape control characters when displaying
VCL content

  All Submissions:

  * [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for the
  same update/change?

  ### New Feature Submissions:

  * [x] Does your submission pass tests?

  ### Changes to Core Features:

  * [x] Have you written new tests for your core changes, as applicable?
  * [x] Have you successfully run tests with your changes locally?

  ### User Impact

  None. Documentation-only change to the changelog.

### Are there any considerations that need to be addressed for release?

  None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants