Skip to content

[CDTOOL-1297] Add support for service validation#1695

Merged
rcaril merged 11 commits intomainfrom
rcaril/CDTOOL-1297-add-support-for-service-version-validate
Mar 17, 2026
Merged

[CDTOOL-1297] Add support for service validation#1695
rcaril merged 11 commits intomainfrom
rcaril/CDTOOL-1297-add-support-for-service-version-validate

Conversation

@rcaril
Copy link
Contributor

@rcaril rcaril commented Mar 16, 2026 •
edited
Loading

Change summary

This PR adds support for the service version validate command, allowing users to determine if the specified version of a service is valid.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
make test TEST_ARGS="-run TestVersionValidate ./pkg/commands/service/version" 
ok      github.com/fastly/cli/pkg/commands/service/version      1.131s

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

rcaril added 8 commits March 9, 2026 09:57
@rcaril
feature(service/validate):
84e051d 
Add support for the 'service version validate' command. This command determines if a given version is valid for activation.
@rcaril
Update validate.go
d24ffca
@rcaril
Update serviceversion_test.go
702d696 
added 'TestVersionValidate' to existing test file.
@rcaril
feature(service/validate):
2c0e110 
Add support for the 'service version validate' command. This command determines if a given version is valid for activation.
@rcaril
Update validate.go
e720a2c
@rcaril
Update serviceversion_test.go
235b539 
added 'TestVersionValidate' to existing test file.
@rcaril
Merge branch 'rcaril/CDTOOL-1297-add-support-for-service-version-vali…
9c7c1cf 
…date' of github.com:fastly/cli into rcaril/CDTOOL-1297-add-support-for-service-version-validate

# Conflicts:
#	pkg/commands/commands.go
@rcaril
update changelog
d5c1642
@rcaril rcaril marked this pull request as ready for review March 16, 2026 19:55
@rcaril rcaril requested a review from a team as a code owner March 16, 2026 19:55
@rcaril rcaril requested a review from philippschulte March 16, 2026 19:55
anthony-gomez-fastly
anthony-gomez-fastly reviewed Mar 17, 2026
View reviewed changes
anthony-gomez-fastly
anthony-gomez-fastly approved these changes Mar 17, 2026
View reviewed changes
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rcaril rcaril merged commit ad4049c into main Mar 17, 2026
13 checks passed
@rcaril rcaril deleted the rcaril/CDTOOL-1297-add-support-for-service-version-validate branch March 17, 2026 14:18
@BrewTestBot BrewTestBot mentioned this pull request Mar 17, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthony-gomez-fastly anthony-gomez-fastly anthony-gomez-fastly approved these changes

@philippschulte philippschulte Awaiting requested review from philippschulte philippschulte is a code owner automatically assigned from fastly/developer-tools

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rcaril @anthony-gomez-fastly