Skip to content

Redis can delete incorrect keys #2150

New issue
New issue
Closed
#2240
Closed
Redis can delete incorrect keys#2150
#2240
Labels
kind/bugpriority/p1
@judahrand

Description

@judahrand
judahrand
opened on Dec 15, 2021

I haven't tested this explicitly but from the data model + this function it looks to be as if two FeatureViews have the same Entities (but are different tables) and one view is deleted the online keys for the other view will also be deleted... This seems like a bit of a flaw either in the Redis data model or in the deletion mechanism.

feast/sdk/python/feast/infra/online_stores/redis.py

Lines 75 to 88 in ec41653

def delete_table_values(self, config: RepoConfig, table: FeatureView):
client = self._get_client(config.online_store)
deleted_count = 0
pipeline = client.pipeline()
prefix = _redis_key_prefix(table.entities)
for _k in client.scan_iter(
b"".join([prefix, b"*", config.project.encode("utf8")])
):
pipeline.delete(_k)
deleted_count += 1
pipeline.execute()
logger.debug(f"Deleted {deleted_count} keys for {table.name}")

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugpriority/p1

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions