feat: Add Snowflake materialization engine#2948
Merged
achals merged 1 commit intofeast-dev:masterfrom Aug 18, 2022
Merged
Conversation
sfc-gh-madkins
commented
Jul 16, 2022
sdk/python/feast/infra/materialization/snowflake/snowflake_engine.py
Outdated
Show resolved
Hide resolved
sfc-gh-madkins
commented
Jul 16, 2022
sdk/python/feast/infra/materialization/snowflake/snowflake_engine.py
Outdated
Show resolved
Hide resolved
sfc-gh-madkins
commented
Jul 16, 2022
sdk/python/feast/infra/materialization/snowflake/snowflake_engine.py
Outdated
Show resolved
Hide resolved
sfc-gh-madkins
commented
Jul 16, 2022
sdk/python/feast/infra/materialization/snowflake/snowflake_engine.py
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2948 +/- ##
==========================================
- Coverage 67.08% 57.80% -9.29%
==========================================
Files 173 209 +36
Lines 15132 17380 +2248
==========================================
- Hits 10152 10046 -106
- Misses 4980 7334 +2354
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sfc-gh-madkins
commented
Jul 16, 2022
sfc-gh-madkins
commented
Jul 16, 2022
sfc-gh-madkins
commented
Jul 16, 2022
sfc-gh-madkins
commented
Jul 21, 2022
achals
reviewed
Jul 22, 2022
Member
achals
left a comment
achals
left a comment
There was a problem hiding this comment.
Overall looks reasonable to me
kevjumba
reviewed
Jul 25, 2022
Collaborator
kevjumba
left a comment
kevjumba
left a comment
There was a problem hiding this comment.
Just need some documentation and a few nits.
sfc-gh-madkins
force-pushed
the
snowflake_materialize
branch
2 times, most recently
from
905cdb4 to
88984d9
Compare
sfc-gh-madkins
force-pushed
the
snowflake_materialize
branch
from
88984d9 to
cf2e3a0
Compare
sfc-gh-madkins
force-pushed
the
snowflake_materialize
branch
2 times, most recently
from
db2a1b7 to
2c61948
Compare
sfc-gh-madkins
force-pushed
the
snowflake_materialize
branch
5 times, most recently
from
747a85f to
fe1834e
Compare
sfc-gh-madkins
force-pushed
the
snowflake_materialize
branch
from
6b17836 to
71ade2e
Compare
adchia
reviewed
Aug 15, 2022
sfc-gh-madkins
force-pushed
the
snowflake_materialize
branch
2 times, most recently
from
456a520 to
b42c452
Compare
sfc-gh-madkins
force-pushed
the
snowflake_materialize
branch
6 times, most recently
from
a0b28b7 to
ff3c697
Compare
achals
reviewed
Aug 17, 2022
sfc-gh-madkins
force-pushed
the
snowflake_materialize
branch
4 times, most recently
from
7d99d8b to
70eb0f1
Compare
Member
|
Tests are red because of a couple of tests that aren't being skipped correctly (since pr-local-integration-tests is triggered on pull_request_target). Going to force merge this in. |
sfc-gh-madkins
force-pushed
the
snowflake_materialize
branch
from
70eb0f1 to
8af1077
Compare
Signed-off-by: Miles Adkins <[email protected]>
sfc-gh-madkins
force-pushed
the
snowflake_materialize
branch
from
8af1077 to
5d0cf95
Compare
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, kevjumba, sfc-gh-madkins The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows Snowflake to be a materialization option when Snowflake is used as an offline store
Which issue(s) this PR fixes:
Fixes #2633